[PATCH 10/13] powerpc: Add arch/powerpc mv64x60 PCI setup

[Stephen Rothwell]

On Wed, 2 May 2007 14:46:09 -0700 "Dale Farnsworth" <dale at farnsworth.org> wrote:
>
> +DECLARE_MUTEX(mv64x60_hs_lock);

Does this need to be global (it is not declared in a header file)?

> +	np = of_find_compatible_node(NULL, NULL, "mv64x60");
> +	if (!np)
> +		return 0;
> +
> +	pdev = platform_device_register_simple("mv64x60", 0, NULL, 0);
> +	if (IS_ERR(pdev))
> +		return PTR_ERR(pdev);

This error leaks a reference count on np.

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070503/9d5395f3/attachment.pgp>