[PATCH 6/13] powerpc: Add arch/powerpc interrupt handler for mv64x60

Stephen Rothwell sfr at canb.auug.org.au
Thu May 3 11:47:05 EST 2007


On Wed, 2 May 2007 14:38:30 -0700 "Dale Farnsworth" <dale at farnsworth.org> wrote:
>
> +DEFINE_SPINLOCK(mv64x60_lock);

Does this need to be global (it is not declared in the header file)?

> +static u32 mv64x60_cached_low_mask  = 0;
> +static u32 mv64x60_cached_high_mask = MV64X60_HIGH_GPP_GROUPS;
> +static u32 mv64x60_cached_gpp_mask  = 0;

Don't initialise things to zero, please.  If you feel it is necessary,
put the "= 0" in a comment.  But generally we know that globals are
initially zero.

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070503/cd969676/attachment.pgp>


More information about the Linuxppc-dev mailing list