[PATCH 13/14] powerpc: add ps3 platform system bus support

David Woodhouse dwmw2 at infradead.org
Tue May 1 16:44:11 EST 2007


On Mon, 2007-04-30 at 17:58 +0200, Olaf Hering wrote:
> On Mon, Apr 30, Geoff Levand wrote:
> 
> > > The generated modalias files do not match anything.
> >  
> > Module support is still todo.  I am just now started on it.  David
> > Woodhouse sent a few patches, but I just merged them in without
> > testing.
> 
> This is my version, compile tested.

I have no particular objection to this, but would observe that it's more
normal to have the number->name mapping done in userspace by modprobe,
rather than inside the kernel.

For now I'd just added explicit aliases like 'MODULE_ALIAS("ps3:3");' to
the modules in question, because I hadn't yet worked out how to do all
the mod_devicetable stuff to pick it out of the match_id in the driver
structure.

-- 
dwmw2




More information about the Linuxppc-dev mailing list