[PATCH 9/13] powerpc: Add arch/powerpc mv64x60 I2C platform data setup

Paul Mackerras paulus at samba.org
Tue May 1 14:58:50 EST 2007


Arnd Bergmann writes:

> We've had discussions about of_platform_bus_probe() on the mailing
> lists and on IRC before. My idea of the long-term goal is that we
> should not call it from the platform specific code, but instead
> globally and add all the devices we find, with exceptions for
> stuff that works differently, like PCI.

I really don't think that is a good idea.

> I think it would be bad to have to add another exception for
> mv64x60 just because the drivers work different from the others.

I don't think it's fair to require extra work now for the sake of
something that will probably never happen.  Creating a platform_device
seems reasonable to me given that the driver is shared between mips
and powerpc.

More generally, the fact that we require a device tree shouldn't be
taken to imply that every device driver should be an
of_platform_driver.

Paul.



More information about the Linuxppc-dev mailing list