[PATCH] powerpc: Disable external interrupts in bootwrapper

Paul Mackerras paulus at samba.org
Wed Mar 28 09:43:07 EST 2007


Mark A. Greer writes:

> Disable external interrupts very early in the bootwrapper in case
> the firmware left a device generating interrupts.

Sounds reasonable, except that I wonder if systems running under a
real OF want to do this...

> +	li	r9,(1<<15)@l	/* Disable external intrs (clear MSR[EE]) */

That will actually get us ffff8000 in r9.

> +	mfmsr	r10
> +	andc	r10,r10,r9

I suggest this sequence instead:

	mfmsr	r10
	rlwinm	r10,r10,0,~(1<<15)	/* clear MSR_EE */

Paul.



More information about the Linuxppc-dev mailing list