MPC83xx SDMR setup error

Segher Boessenkool segher at kernel.crashing.org
Tue Mar 27 08:53:42 EST 2007


> Can you send this with a more proper header/subject and Signed-off-
> by, according to Documentation/SubmittingPatches

>> -	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 >>
>> +	out_be32(&sdma->sdmr, (QE_SDMR_GLB_1_MSK | (0x1 <<
>>  					QE_SDMR_CEN_SHIFT)));

When you resend, please change the line break to
something more reasonable too (like, at the | sign) --
it might have avoided this bug in the first place.


Segher




More information about the Linuxppc-dev mailing list