[PATCH 5/6] bootwrapper: Add a cuImage target.

Scott Wood scottwood at freescale.com
Sat Mar 24 02:18:36 EST 2007


On Fri, Mar 23, 2007 at 04:40:48PM +1100, David Gibson wrote:
> > +cuboot-plats :=
> > +src-plat := of.c $(cuboot-plats:%=cuboot-%.c)
> 
> Rather than this special cuboot-plats stuff, I suggest you just list
> each cuboot platform in src-plat independently.

OK, I suppose the number of platforms will be few enough for that.

> We can also git rid of the need for a CONFIG option specifying the dts
> (and thereby taking us back to the one-config-per-board era) by using
> rules like:
> 
> $(obj)/uImage.83xx.%: vmlinux $(wrapperbits) $(srctree)/$(src)/dts/%.dts
> 	$(call if_changed,wrap,cuboot-83xx,$(srctree)/$(src)/dts/$*)

But then you can't build with an out-of-tree dts.  It's not a huge deal,
but still...  What's wrong with a config option?

> And to get the right things built use something like:
> image-$(CONFIG-83xx)	+= $(mpx83xx-boards:%=uImage.83xx.%)

And then I'd have to determine which boards are supported by the kernel
that was built, so I don't trick the user into thinking that valid images
were produced for every single 83xx.  I'd also have to enumerate every
single board in the makefile, which would suck.

> Or optionally add a batch of bool config options for each board
> variant.

I don't want to do that.  There shouldn't have to be a 1-1 correspondence
between each dts file and anything in the kernel.

-Scott



More information about the Linuxppc-dev mailing list