[Fwd: [PATCH Resend 01/02] Add Linux ASMP support for MPC8641D]

Yoder Stuart-B08248 stuart.yoder at freescale.com
Fri Mar 23 02:32:33 EST 2007


> +		mpic: pic at 40000 {
> +			clock-frequency = <0>;
> +			interrupt-controller;
> +			#address-cells = <0>;
> +			#interrupt-cells = <2>;
> +			reg = <40000 40000>;
> +			built-in;
> +			compatible = "chrp,open-pic";
> +			device_type = "open-pic";
> +			big-endian;
> +			interrupts = <
> +			18 2 49 2 19 2
> +			2a 2 2b 2 4a 1
> +			1d 2 1e 2 22 2
> +			23 2 24 2 28 2
> +			>;
> +		};
> +	};
> +};

I think using the 'interrupts' property in this way is bad.  It's 
being used to tell the pic which interrupts belong to it. 

The problem is that the interrupts property is being overloaded
and used for a completely different purpose than that which
it was originally intended and documented.  Interrupt controllers
should not have an interrupts property.

The only reason I can see to do this is as a convenience to avoid
walking the device tree.   The pic code should walk the device tree
to determine the irq numbers the running core.

Stuart



More information about the Linuxppc-dev mailing list