[PATCH 2/4] powerpc: Add device tree utility functions to zImage

David Gibson david at gibson.dropbear.id.au
Thu Mar 22 14:02:58 EST 2007


On Wed, Mar 21, 2007 at 09:03:02AM -0600, Milton Miller wrote:
> 
> Following your reply to Scott's comments about space in the xlate_reg
> thread, how about splitting the ones used in main.c which will always
> be included from the others that are more for device tree pokers.

Yeah, I guess.

> For that matter, your streamlining adds runtime overhead.  Why not
> cache the checked or created phandle?

Well, I made a judgeement that source simplicity was more valuable
than runtime speed.  However, in the second spin, I've reconsidered
and gotten rid of the dt_path_{get,set}prop functions entirely which
addresses both concerns above.

> Also, in dt_path_getprop, did you want to call finddevice instead of
> testing the function is not weak and undefined?

Yes.  Fixed now.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson



More information about the Linuxppc-dev mailing list