[PATCH 1/5] powerpc: generic time suspend/resume code

Guennadi Liakhovetski g.liakhovetski at gmx.de
Tue Mar 20 08:51:15 EST 2007


On Mon, 19 Mar 2007, Benjamin Herrenschmidt wrote:

> On Mon, 2007-03-19 at 11:53 +0100, Johannes Berg wrote:
> > plain text document attachment (001-time-resume.patch)
> > This patch removes the time suspend/restore code that was done through
> > a PMU notifier in arch/platforms/powermac/time.c.
> > 
> > Instead, introduce arch/powerpc/sysdev/timer.c which creates a sys
> > device and handles time of day suspend/resume through that.
> > 
> > This should probably be replaced by using the generic RTC framework
> > but for now it gets rid of the arcane powermac specific hack.
> > 
> > Signed-off-by: Johannes Berg <johannes at sipsolutions.net>
> 
> Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Not sure I'm convinced it's a good thing to do...

As far as I understand it duplicates the functionality proposed in this 
thread:

http://lists.linux-foundation.org/pipermail/linux-pm/2007-February/thread.html#4949

and by committing it now we'll delay the powerpc migration to generic rtc. 
How about this: you give me a week before committing this (and any 
depending) patches, in 1 week I send an email with an estimate whether I'd 
be able to do the convertion (without being able to test - others will 
have to do that) and how long I expect to need for that. If we find it 
acceptible, we'll do that, if not - in one week we still can commit these 
patches - 2.6.21 either will not be there yet by then or the window will 
still be open...

David, what's the status of that your patch?

Notice also, that my linkstation suspend patch in its present form also 
uses the previous version of this patch from Johannes', but I'd rather 
delay its acceptance upstream and directly go for the ultimate solution.

Thanks
Guennadi
---
Guennadi Liakhovetski



More information about the Linuxppc-dev mailing list