[PATCH][POWERPC] QE: Make QUICC Engine support a configurableoption

[Kumar Gala]

On Mar 14, 2007, at 10:02 PM, Li Yang-r58472 wrote:

>> -----Original Message-----
>> From: linuxppc-dev-bounces+leoli=freescale.com at ozlabs.org
>> [mailto:linuxppc-dev-bounces+leoli=freescale.com at ozlabs.org] On  
>> Behalf
> Of Timur
>> Tabi
>> Sent: Thursday, March 15, 2007 3:36 AM
>> To: Phillips Kim-R1AAHA
>> Cc: linuxppc-dev at ozlabs.org
>> Subject: Re: [PATCH][POWERPC] QE: Make QUICC Engine support a
> configurableoption
>>
>> Kim Phillips wrote:
>>> On Wed, 14 Mar 2007 13:15:05 -0500 (CDT)
>>> Kumar Gala <galak at kernel.crashing.org> wrote:
>>>
>>>>  arch/powerpc/Kconfig                |    8 --------
>>>>  arch/powerpc/platforms/83xx/Kconfig |   12 ++++++++++--
>>>>  2 files changed, 10 insertions(+), 10 deletions(-)
>>>
>>> What about 85xx QE support?
>>
>> Kumar and I talked about it.  85xx support will be added when QE  
>> works
> on 85xx.
>> However,
>> the patch still needs changes.  To allow each CPU family to have its
> own QE option,
>> we'll
>> need to define something like QUICC_ENGINE_83xx and  
>> QUICC_ENGINE_85xx,
> and then
>> have
>> something like this:
>>
>> config QUICC_ENGINE
>> 	bool
>> 	default y if QUICC_ENGINE_83xx || QUICC_ENGINE_85xx
>
> I don't think we need these new options.  If there are differences
> between the two SOC versions, presumably not too many, we can address
> them in device tree.  It's better to leave the QUICC_ENGINE option at
> arch/powerpc/Kconfig level, IMHO.


The issue isn't dealing with differences between 83xx/85xx.  Its  
allowing the choice for only those two subarchs.

- k