Fw: [PATCH 2/15] Automatically lmb_reserve() initrd

Stephen Winiecki stevewin at us.ibm.com
Wed Mar 14 04:43:00 EST 2007


Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote on 03/12/2007 
05:25:32 PM:

> 
> > It might be helpful if some kind of message was surfaced if the 
> > initrd-start/end properties didn't exist in the dt, esp. since it may 
not 
> > be well known initially as a dts definition requirement/option (voice 
of 
> > experience :)).  In general I think surfacing messages for any 
properties 
> > which are detected as not existing and which might be normally 
expected 
> > would be a good thing as people get familiar with defining dts files 
and 
> > specifying properties for their platforms. 
> 
> Well.. initrd is totally optional...
> 

I understand - I guess I am just thinking of the case where someone didn't 
define the property because they were not aware of it - esp in this case 
where the existence of the property name is all that is required for the 
value to be filled in properly by the init code.  Instead of just setting 
the start/end to 0 - maybe include a message something like (even if 
debug) "No initird-start/end property found - setting to 0" - just a minor 
example.  The larger point also being that defining dts files and 
properties may be a new thing for many people with the new support - might 
be helpful to surface missing properties when appropriate (I'm not 
condoning mass amounts of messages for everything). 




More information about the Linuxppc-dev mailing list