[PATCH 15/19] bootwrapper: Add dt_ops methods.

Scott Wood scottwood at freescale.com
Wed Mar 14 02:29:44 EST 2007


On Mon, Mar 12, 2007 at 03:49:13PM -0700, Mark A. Greer wrote:
> On Mon, Mar 12, 2007 at 02:42:01PM -0600, Scott Wood wrote:
> 
> <snip>
> 
> > diff --git a/arch/powerpc/boot/ops.h b/arch/powerpc/boot/ops.h
> > index 2b569ad..6b4fd9b 100644
> > --- a/arch/powerpc/boot/ops.h
> > +++ b/arch/powerpc/boot/ops.h
> 
> <snip>
> 
> > +static inline int setprop_str(void *devp, const char *name, const char *buf)
> > +{
> > +	if (dt_ops.setprop)
> > +		return dt_ops.setprop(devp, name, buf, strlen(buf));
> 
> Shouldn't that be "return dt_ops.setprop(devp, name, buf, strlen(buf) + 1);" ?

Oops.  Yes.

-Scott



More information about the Linuxppc-dev mailing list