[PATCH] powerpc: automatically select QE options

Kumar Gala galak at kernel.crashing.org
Wed Mar 14 01:38:37 EST 2007


On Mar 13, 2007, at 5:24 AM, Li Yang-r58472 wrote:

> Timur,
>
> ACK on removing choices for UCC_FAST and UCC_SLOW.
>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 6dfbd52..54dd66c 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -396,8 +396,6 @@ endchoice
>>
>>  config QUICC_ENGINE
>>  	bool
>> -	depends on PPC_MPC836x || PPC_MPC832x
>> -	default y
>>  	help
>>  	  The QUICC Engine (QE) is a new generation of communications
>>  	  coprocessors on Freescale embedded CPUs (akin to CPM in older
> chips).
>
> But I'd prefer QUICC_ENGINE option to depend on chip models rather  
> than
> boards.  Also the comment doesn't reflect this change.

We are going to make QUICC_ENGINE a selectable option like it is for  
CPM2.  I agree that selectable option should depend on chip rather  
than board.

- k



More information about the Linuxppc-dev mailing list