[PATCH] Add irq host and hwirq pair fields to output whenshowing interrupts.
Zhang Wei-r63237
Wei.Zhang at freescale.com
Tue Mar 13 20:32:21 EST 2007
> On Tue, 2007-03-13 at 11:19 +0800, Zhang Wei wrote:
> > Signed-off-by: Zhang Wei <wei.zhang at freescale.com>
> > ---
> > arch/powerpc/kernel/irq.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> > index 919fbf5..2a30ffd 100644
> > --- a/arch/powerpc/kernel/irq.c
> > +++ b/arch/powerpc/kernel/irq.c
> > @@ -194,7 +194,7 @@ #else
> > seq_printf(p, "%10u ", kstat_irqs(i));
> > #endif /* CONFIG_SMP */
> > if (desc->chip)
> > - seq_printf(p, " %s ", desc->chip->typename);
> > + seq_printf(p, " (%3d) @%s ",
> (irq_map[i].host->revmap_type == IRQ_HOST_MAP_LEGACY) ? i :
> virq_to_hw(i), desc->chip->typename);
> > else
> > seq_puts(p, " None ");
> > seq_printf(p, "%s", (desc->status & IRQ_LEVEL)
> ? "Level " : "Edge ");
>
> Well, first, we shouldn't modify the output of
> /proc/interrupts as this
> will likely break all sort of userland tools displaying it (well, I
> think).
>
> Now, regarding the patch itself, printing the hw irq is not
> that useful
> without some indication of which host it belongs to. Best is to add a
> name() or something like that to the host ops.
>
Sure, can I use the PIC controller node full name from of_tree as the
host name?
Do you prefer debugfs instead of /proc/interrupts?
Thanks!
Zhang Wei
More information about the Linuxppc-dev
mailing list