[patch][5/5] powerpc V2: Add the general support for EmbeddedFloating-Point instructions

Zhu Ebony-r57400 ebony.zhu at freescale.com
Thu Mar 8 18:12:02 EST 2007


 

> -----Original Message-----
> From: linuxppc-dev-bounces+ebony.zhu=freescale.com at ozlabs.org 
> [mailto:linuxppc-dev-bounces+ebony.zhu=freescale.com at ozlabs.or
> g] On Behalf Of Kumar Gala
> Sent: Friday, February 23, 2007 2:23 AM
> To: Sergei Shtylyov
> Cc: linuxppc-dev at ozlabs.org; paulus at samba.org
> Subject: Re: [patch][5/5] powerpc V2: Add the general support 
> for EmbeddedFloating-Point instructions
> 
> 
> On Feb 22, 2007, at 10:56 AM, Sergei Shtylyov wrote:
> 
> > Hello.
> >
> > Segher Boessenkool wrote:
> >>>>>  arch/powerpc/sysdev/sigfpe_handler.c |  361
> >>>>> ++++++++++++++++++++++++++++++++++
> >
> >>>>    I'm sorry, but is sysdev/ really fitting place for this file?
> >>>> Shouldn't it be under kernel/ or math-emu/ instead?
> >
> >>>     Also, the name doesn't look fittingto me, since we're not 
> >>> handling
> >>> *SIGFPE* here (which is for userland), we're handling SPE 
> >>> exceptions.
> >
> >> arch/powerpc/math-emu/spe/<whatever>.c seems like a good place?
> >
> >     Yeah, certainly more like it. :-)
> >
> >> Segher
> 
> Agreed, this shouldn't have been in sysdev, didn't notice that :)
> 
> We should probably rename this as well, since its not just 
> handling the sigfpe part, but the actual fixup/emulation.
> 
> - k

Hi All,

Base on your suggestion, how about move sigfpe_handler.c to
arch/powerpc/math-emu/spe/spe_handler.c? Or do you have any other
suggestions on file name?

B.R.
Ebony



More information about the Linuxppc-dev mailing list