[PATCH] Better timer and RTC handling for 8641HPCN.

[Kumar Gala]

On Mar 7, 2007, at 11:38 PM, Zhang Wei-r63237 wrote:

> In fact, I've included <asm-generic/rtc.h> in mpc86xx_hpcn.c file, and
> the file linux/mc146818rtc.h was included in asm-generic/rtc.h.

Uugh, sorry... was looking at asm/rtc.h not asm-generic/rtc.h (thus  
my confusion)

I don't think we should add new users of the old rtc code at this  
point.  We really should look at using the rtc class code.

I'm going to start a new thread on figuring out what we need to do  
for ppc_md.set_rtc_time/ppc_md.get_rtc_time and the rtc subsystem.

- k

>
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak at kernel.crashing.org]
>> Sent: Thursday, March 08, 2007 10:47 AM
>> To: Zhang Wei-r63237
>> Cc: Wood Scott-B07421; Loeliger Jon-LOELIGER; linuxppc-dev at ozlabs.org
>> Subject: Re: [PATCH] Better timer and RTC handling for 8641HPCN.
>>
>>
>> On Mar 7, 2007, at 7:56 PM, Zhang Wei-r63237 wrote:
>>
>>> Hi, Kumar and Scott,
>>>
>>> Thanks for your review. :-)
>>>
>>> The MPC8641HPCN's RTC is a module of ULI1575, which is a legacy RTC
>>> device with operate by I/O ports 0x70 and 0x71. So I use functions
>>> defined in asm-generic/rtc.h to set and get rtc time.
>>
>> Than you need to include <linux/mc146818rtc.h> in the file to
>> get the
>> CMOS_* defn.
>>
>> - k
>>
>>
>>