[PATCH] Better timer and RTC handling for 8641HPCN.

[Zhang Wei-r63237]

Hi, Kumar and Scott,
 
Thanks for your review. :-)

The MPC8641HPCN's RTC is a module of ULI1575, which is a legacy RTC
device with operate by I/O ports 0x70 and 0x71. So I use functions
defined in asm-generic/rtc.h to set and get rtc time.

Best Regards,
Zhang Wei

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Thursday, March 08, 2007 3:49 AM
> To: Wood Scott-B07421
> Cc: Loeliger Jon-LOELIGER; Zhang Wei-r63237; linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH] Better timer and RTC handling for 8641HPCN.
> 
> 
> On Mar 7, 2007, at 1:34 PM, Scott Wood wrote:
> 
> > On Wed, Mar 07, 2007 at 01:19:29PM -0600, Kumar Gala wrote:
> >> On Mar 7, 2007, at 12:49 PM, Jon Loeliger wrote:
> >>> From: Zhang Wei <wei.zhang at freescale.com>
> >>>
> >>> Give more IRQ numbers for MPIC IPIs and TIMERs use.
> >>> Added generic RTC support for MPC8641HPCN.
> >>>
> >>> Signed-off-by: Zhang Wei <wei.zhang at freescale.com>
> >>> Signed-off-by: Jon Loeliger <jdl at freescale.com>
> >>
> >> Nack.
> >>
> >> You can't call the generic set_rtc_time from the
> >> ppc_md.set_rtc_time.  Take a look at:
> >>
> >> http://ozlabs.org/pipermail/linuxppc-dev/2007-January/030440.html
> >
> > set_rtc_time != rtc_set_time.  The latter is the one that 
> goes through
> > the drivers/rtc stuff and needs a workqueue; the former 
> (which this  
> > patch
> > uses) is in asm-generic/rtc.h, and appears to be interrupt-safe.
> 
> I ah, didn't notice.. Well I don't think 
> set_rtc_time/get_rtc_time do  
> anything useful for most ppc's, since it seems they use CMOS_READ/ 
> CMOS_WRITE which is only defined in asm/mc146818rtc.h
> 
> - k
>