[PATCH] Better timer and RTC handling for 8641HPCN.

Scott Wood scottwood at freescale.com
Thu Mar 8 06:34:38 EST 2007


On Wed, Mar 07, 2007 at 01:19:29PM -0600, Kumar Gala wrote:
> On Mar 7, 2007, at 12:49 PM, Jon Loeliger wrote:
> > From: Zhang Wei <wei.zhang at freescale.com>
> >
> > Give more IRQ numbers for MPIC IPIs and TIMERs use.
> > Added generic RTC support for MPC8641HPCN.
> >
> > Signed-off-by: Zhang Wei <wei.zhang at freescale.com>
> > Signed-off-by: Jon Loeliger <jdl at freescale.com>
> 
> Nack.
> 
> You can't call the generic set_rtc_time from the  
> ppc_md.set_rtc_time.  Take a look at:
> 
> http://ozlabs.org/pipermail/linuxppc-dev/2007-January/030440.html

set_rtc_time != rtc_set_time.  The latter is the one that goes through
the drivers/rtc stuff and needs a workqueue; the former (which this patch
uses) is in asm-generic/rtc.h, and appears to be interrupt-safe.

-Scott



More information about the Linuxppc-dev mailing list