[PATCH] [POWERPC] fix up log_plpar_hcall_return

[Stephen Rothwell]

[sfr done Blue Hair]

Hi Will,

On Tue, 06 Mar 2007 17:11:41 -0600 Will Schmidt <will_schmidt at vnet.ibm.com> wrote:
>
> This is mostly cosmetic.  This updates log_plpar_hcall_return() to use a
> case statement rather than an if-then-else jumble, and moves it to
> rtas.c where it can be near the other rtas related functions.

You are moving a static function from the only file that calls it.  You
are exporting it when the only callers are in a file that cannot be part
of a module and you are (maybe) optimizing something that is only used in
error paths.

Sorry, but unless you are doing to introduce others uses, that I don't
see that this change helps.

[sfr redons normal hair]

I don't mean to sound harsh  :-)

--
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070307/dab1fe8a/attachment.pgp>