[PATCH 09/15] [POWERPC] 86xx: Add uli1575 pci-bridge sector to MPC8641HPCN dts file.

Andy Fleming afleming at freescale.com
Thu Jun 28 05:57:34 EST 2007


On Jun 26, 2007, at 20:16, Kumar Gala wrote:

> From: Wade Farnsworth <wfarnsworth at mvista.com>
>
> This adds device nodes for the PCI bridges as well as the ISA  
> devices on
> the newer revision MPC8641HPCN.  It also adds the PCI ranges to the  
> soc
> node so that address translation for the ISA devices works properly.

>
> -		ranges = <0 f8000000 00100000>;
> -		reg = <f8000000 00100000>;	// CCSRBAR 1M
> +		ranges = <00001000 f8001000 000ff000
[...]
> +		reg = <f8000000 00001000>;	// CCSRBAR


This can't be right, and I suspect it will break any kernel access to  
the first 0x1000 bytes of the CCSR_BAR space.  reg should actually  
describe the register space of the SOC.  If ranges needs to specify  
that, too, they should be able to be redundant.  But this looks like  
a big hack, to me.  Am I missing something?


Andy





More information about the Linuxppc-dev mailing list