[PATCH] ppc: Marvell mv64x60 drivers for ppc platforms fix

Kumar Gala galak at kernel.crashing.org
Mon Jun 25 11:49:58 EST 2007


On Jun 24, 2007, at 5:46 PM, Dale Farnsworth wrote:

> In article <200706241552.31483.yur at emcraft.com> you write:
>>  This patch fixes the issue of erroneously involving the
>> arch/powerpc/sysdev/mv64x60*.c files into the compilation
>> process for ppc- (not powerpc-) based platforms (e.g.,
>> P3M750).
>>
>>  Signed-off-by: Yuri Tikhonov <yur at emcraft.com>
>>
>> --
>>
>> diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/ 
>> Makefile
>> index c3ce0bd..25eaa14 100644
>> --- a/arch/powerpc/sysdev/Makefile
>> +++ b/arch/powerpc/sysdev/Makefile
>> @@ -17,7 +17,9 @@ obj-$(CONFIG_FSL_PCIE)		+= fsl_pcie.o
>>  obj-$(CONFIG_TSI108_BRIDGE)	+= tsi108_pci.o tsi108_dev.o
>>  obj-$(CONFIG_QUICC_ENGINE)	+= qe_lib/
>>  mv64x60-$(CONFIG_PCI)		+= mv64x60_pci.o
>
> Shouldn't the above line also be placed inside the of following ifeq ?
>
>> +ifeq ($(CONFIG_PPC_MERGE),y)
>>  obj-$(CONFIG_MV64X60)		+= $(mv64x60-y) mv64x60_pic.o mv64x60_dev.o
>> +endif
>>
>>  # contains only the suspend handler for time
>>  obj-$(CONFIG_PM)		+= timer.o

Also, lets just move these into the existing ifeq  
($CONFIG_PPC_MERGE,y) block in that makefile rather than introducing  
a new one.

- k



More information about the Linuxppc-dev mailing list