[PATCH] Fix I8042 IRQs on MPC8641 HPCN

Wade Farnsworth wfarnsworth at mvista.com
Thu Jun 21 02:16:56 EST 2007


On Wed, 2007-06-20 at 18:07 +0200, Segher Boessenkool wrote:
> >>> 	 * IRQ 9:  Level
> >>> 	 * IRQ 10: Level
> >>> 	 * IRQ 11: Level
> >>> -	 * IRQ 12: Level
> >>> +	 * IRQ 12: Edge
> >>> 	 * IRQ 14: Edge
> >>> 	 * IRQ 15: Edge
> >>> 	 */
> >>> -	outb(0xfa, 0x4d0);
> >>> -	outb(0x1e, 0x4d1);
> >>> +	outb(0xf8, 0x4d0);
> >>> +	outb(0x0e, 0x4d1);
> >> The comment doesn't mention IRQ13.  You're changing IRQ9
> >> to edge as well; is this an accident?
> >
> >    Whare -- I'm only seeing bit 1 changing which corresponds to IRQ1 
> > and is reserved (0) anyway.
> 
> Uh yeah, bit 1, it's hard to count these single-byte quantities :-)

Yep, only IRQ's 1 and 12 should be changed here.

> 
> >>  If not, you need to change the comment too.
>

I'm not the original author of the comment, but I think it's only
mentioning the IRQ's whose triggering is being modified here.  The
omitted IRQ's already had the correct triggering.

In any case, I can clarify the comment to make it more clear.

--Wade




More information about the Linuxppc-dev mailing list