[PATCH] rheap: eliminates internal fragments caused by alignment

Joakim Tjernlund joakim.tjernlund at transmode.se
Mon Jun 18 23:24:42 EST 2007


On Mon, 2007-06-18 at 15:31 +0300, Pantelis Antoniou wrote:
> On 18 Ιουν 2007, at 3:25 ΜΜ, Joakim Tjernlund wrote:
> 
> > On Mon, 2007-06-18 at 15:14 +0300, Pantelis Antoniou wrote:
> >> Hi Li,
> >>
> >> The patch appears fine at first glance.
> >>
> >> I'm really curious what kind of alignment do you use in order to  
> >> have so
> >> much wasted space that re-inserting the leftovers makes so much of a
> >> difference.
> 
> Jocke,
> 
> Ugh, 256?

Yes, the ucc_geth needs lots of alignment. Leo can tell you more :)

> 
> That's not nice at all.
> I'm not sure that even then you're going to have any guarantees that
> the allocations will be successful.
> 
> I'm afraid that in those case it would be better for the board
> platform setup to have the space preallocated according to the BSP
> requirements.

Maybe, but without the PATCH you will run out of space very quickly
and you cannot bring up 3 ethernet interfaces. Rheap is plain wrong
as is today and needs this patch.

 Jocke

> 
> Just my $0.02.
> 
> -- Pantelis




More information about the Linuxppc-dev mailing list