[patch 05/30] PS3: Use ioremap_flags

Arnd Bergmann arnd at arndb.de
Wed Jun 13 19:10:48 EST 2007


On Tuesday 12 June 2007, Geoff Levand wrote:
> -       spu->problem = ioremap(spu->problem_phys,
> -               sizeof(struct spu_problem));
> +       spu->problem = (__force void *)ioremap_flags(spu->problem_phys,
> +               sizeof(struct spu_problem), _PAGE_NO_CACHE);
> +

Unlike the local_store member, of struct spu, ->problem and ->priv2
members are __iomem, so you should not do a __force cast here.

Other than that, the patch looks good.

Note that I may reply faster is you send your messages to arnd at arndb.de
instead of arnd.bergmann at de.ibm.com.

	Arnd <><


More information about the Linuxppc-dev mailing list