[PATCH v4]: Fix e500 v2 core reboot bug

Li Yang-r58472 LeoLi at freescale.com
Wed Jun 13 18:16:24 EST 2007


> -----Original Message-----
> From: Zang Roy-r61911 [mailto:tie-fei.zang at freescale.com]
> Sent: Wednesday, June 13, 2007 4:07 PM
> To: Segher Boessenkool
> Cc: Li Yang-r58472; linuxppc-dev list; Paul Mackerras
> Subject: Re: [PATCH v4]: Fix e500 v2 core reboot bug
> 
> On Wed, 2007-06-13 at 15:55, Segher Boessenkool wrote:
> > > It will be good if you do:
> > > +                             printk (KERN_EMERG "Error: reset
> > > control"
> > > +                                     "register not mapped,
> > > spinning!\n");
> > >
> > > Instead of:
> > > +                             printk (KERN_EMERG "Error: reset
> > control
> > > \
> > > +                                     register not mapped,
> > > spinning!\n");
> >
> > Except you forgot a space.  Too much whitespace in the
> > resulting string is bad, but too little doesn't help
> > either ;-)
> I noticed that space, except that I am not sure the difference between
\
> and ".
The difference is that you will get all the indentation in the next line
into the string if you use \. :-)
The output will be "Error: reset control<tab><tab><tab><tab> register
not mapped, spinning!\n"

- Leo



More information about the Linuxppc-dev mailing list