[PATCH v4]: Fix e500 v2 core reboot bug
Zang Roy-r61911
tie-fei.zang at freescale.com
Wed Jun 13 17:14:58 EST 2007
On Wed, 2007-06-13 at 15:03, Segher Boessenkool wrote:
> > Fix the reset bug on 8548CDS board.
>
> > Segher, do you have any comment?
>
> This one looks fine, only some cosmetics left :-)
>
> > If yes, I will revise again; if No, pick it up!
>
> Well it's not me who picks things up around here...
I know, it's Paul or Kumar! I just like to hear your valuable comment...
>
> > + printk (KERN_EMERG "Error: reset
> control \
> > + register not mapped,
> spinning!\n");
>
> ...(... "bla bla bla "
> "bla bla bla\n");
>
> instead? Or there'll be a lot of whitespace in your string.
I just do not know the difference of these two style.
> I don't see anything spinning like the warning says, btw (or
> it must be something in abort()?)
You can find the similar thing in 83xx/mis.c
[snip]
} else {
printk (KERN_EMERG "Error: Restart registers not mapped,
spinning!\n");
}
[snip]
Roy
More information about the Linuxppc-dev
mailing list