[PATCH 1/6] 82xx: Add the support of Wind River SBC PowerQUICCII 82xx
Scott Wood
scottwood at freescale.com
Tue Jun 12 07:02:01 EST 2007
On Fri, Jun 08, 2007 at 04:48:53PM +0800, Mark Zhan wrote:
> + new_bus->phy_mask = 0xFFFFFFFF;
> + for (i = 0; i < PHY_MAX_ADDR; i++)
> + if (pdata->irq[i] != -1)
> + new_bus->phy_mask &= ~(1 << i);
> +
This assumes that all PHYs have an IRQ.
I have patches forthcoming to of_platform-ize this code when
CONFIG_PPC_MERGE is defined; phy_mask will be set properly then.
Though, I notice that this is the only driver that sets phy_mask. Is
there any reason we can't just leave the mask clear, and let the probe
for non-existent phys fail?
-Scott
More information about the Linuxppc-dev
mailing list