[PATCH] When checking I8042 io port, use of_find_compatible_node() instead of of_find_node_by_type()

Segher Boessenkool segher at kernel.crashing.org
Thu Jun 7 23:05:51 EST 2007


> In check_legacy_ioport(), instead of using of_find_node_by_type() to
> find the 8042 node, use of_find_compatible_node() to find either the
> keyboard or mouse node.

Why?

>  	switch(base_port) {
>  	case I8042_DATA_REG:
> -		np = of_find_node_by_type(NULL, "8042");
> +		np = of_find_compatible_node(NULL, NULL, "pnpPNP,303");
> +		if (!np)
> +			np = of_find_compatible_node(NULL, NULL, "pnpPNP,f03");
> +		if (np) {
> +			parent = of_get_parent(np);
> +			of_node_put(np);
> +			np = parent;
> +		}

This breaks other boards using 8042, if those exist --
if this code is board-specific, it is in the wrong file.


Segher




More information about the Linuxppc-dev mailing list