[patch 07/18] PS3: Make ps3av.h usable from user space

[Geert Uytterhoeven]

On Wed, 6 Jun 2007, Christoph Hellwig wrote:
> On Tue, Jun 05, 2007 at 08:00:07PM -0700, Geoff Levand wrote:
> > The user applications to manage the PS3 AV modes can use values
> > defined in this header.
> 
> NACK.  First please don't introduce new unifdef-y headers but always
> separated them.  Second I don't see any of the values actually used
> in a user<->kerne interface.  If the application only happens to use
> the same values it should ship a copy of the header intead.

ps3videomode (from ps3-utils,
git://git.kernel.org/pub/scm/linux/kernel/git/geoff/ps3-utils.git) uses the
PS3AV_MODE_* definitions for the PS3FB_IOCTL_[SG]ETMODE ioctls on /dev/fb0.

But it indeed just uses a few values, and ps3videomode.c already handles the
case were <asm/ps3av.h> is not available, so I guess we can drop the export.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium