[PATCH] of_serial: ignore unknown serial port

kouish kou.ishizaki at toshiba.co.jp
Wed Jun 6 19:28:20 EST 2007


> Ishizaki Kou writes:
> 
> > Current of_serial driver assumes unknown serial port to be 8250. But
> > this behavior may cause fatal problems when the serial port is not
> > 8250. This patch corrects probe routine to ignore unknown 
> serial port.
> > 
> > Signed-off-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>
> > Cc: Arnd Bergmann <arnd at arndb.de>
> 
> Is this a bugfix that needs to go in 2.6.22?  Likewise, is your next
> patch (of_serial: add port type checking) needed in 2.6.22?
> 
> Paul.

Paul-san,

Thank you to ask me about our patches to of_serial driver.

We need the 'ignore unknown serial port' patch in 2.6.22 because
assuming an unknown port as 8250 may cause fatal problems on Celleb
with our new device tree which has 'serial' type device nodes. These
serial ports are not 8250.

On the other hand, we have no problem even if the 'of_serial: add port
type checking' patch will be merged in 2.6.23.

Best regards,
Kou Ishizaki




More information about the Linuxppc-dev mailing list