[PATCH 8/8] Wrote quirk_mpc8641_transparent() to initialize bridge resources.
Jon Loeliger
jdl at freescale.com
Tue Jun 5 05:32:35 EST 2007
On Mon, 2007-06-04 at 00:55, Milton Miller wrote:
> This is totally unreadable. include/linux/pci_ids.h exists for a
> reason,
> please use it. At least the vendor should be in there.
>
> If you want to define the device id with the same naming convention
> but in the local source file, I won't object.
> Please use the (new) helper of_read_number in prom.h.
> milton
>
> PS: how about create instead of wrote in the subject?
All yup.
Thanks,
jdl
More information about the Linuxppc-dev
mailing list