[PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file.
Jon Loeliger
jdl at freescale.com
Tue Jun 5 04:49:27 EST 2007
On Sat, 2007-06-02 at 18:50, Benjamin Herrenschmidt wrote:
> Minor nits (in addition to needing a "reg" property)
>
> > +
> > + i8259: i8259 at 4d0 {
>
> Name should probably be "interrupt-controller" as well to follow the
> recommended naming practice.
>
> > + clock-frequency = <0>;
> > + interrupt-controller;
> > + device_type = "interrupt-controller";
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> > + built-in;
> > + compatible = "chrp,iic";
> > + big-endian;
>
> big-endian ? On a 8259 ?
>
> > + interrupts = <49 2>;
> > + interrupt-parent =
> > + <&mpic>;
> > + };
> > + };
> > + };
> > };
> >
> > };
>
Since the interrupt controller issues are a bit unrelated
to the PCI-Express enablement patches here, I'll submit a
follow-up patch set to clean them up.
Thanks,
jdl
More information about the Linuxppc-dev
mailing list