[PATCH] powerpc: Create "rom" (MTD) device prpmc2800

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Jun 4 07:12:00 EST 2007


On Sun, 2007-06-03 at 20:22 +0400, Sergei Shtylyov wrote:
> 
>     No, it doesn't -- since that info is almost *absolutely* useless
> (the only 
> exception is "cfi") in the context of Linux MTD subsys.
>     Please, try to understand that knowing that chip is CFI compatible
> in 
> itself doesn't yet guarantee that you can access the chip -- it all
> depends on 
> its mapping to the real physical address range, therefore this group
> IMO 
> cannot even constitute a valid "compatible" property.

You make no sense to me. It's like saying that knowing that a 8250 chip
on ISA cannot be accessed if you don't know it's IO ports so it
shouldn't say "8250" in compatible property ?!?!?!?

Also, whatever shortcomings of the linux MTD drivers are totally
irrelevant to what is correct to have in a device-tree. While we do
tailor our device-tree specification around linux needs in most cases,
there are cases like this one where common sense should be enough to
understand that it's not because the linux MTD subsystem, as of today,
cannot be told what programming interface to use, that we shouldn't
provide that information in the tree.

Regarding physical address ranges for the flash mapping, I suppose the
best is to define a property for flash chips for it. 





More information about the Linuxppc-dev mailing list