[PATCH 2/8] Add uli1575 pci-bridge sector to MPC8641HPCN dts file.
Benjamin Herrenschmidt
benh at kernel.crashing.org
Sun Jun 3 09:50:53 EST 2007
Minor nits (in addition to needing a "reg" property)
> +
> + i8259: i8259 at 4d0 {
Name should probably be "interrupt-controller" as well to follow the
recommended naming practice.
> + clock-frequency = <0>;
> + interrupt-controller;
> + device_type = "interrupt-controller";
> + #address-cells = <0>;
> + #interrupt-cells = <2>;
> + built-in;
> + compatible = "chrp,iic";
> + big-endian;
big-endian ? On a 8259 ?
> + interrupts = <49 2>;
> + interrupt-parent =
> + <&mpic>;
> + };
> + };
> + };
> };
>
> };
More information about the Linuxppc-dev
mailing list