[PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

[Zhang Wei-r63237]

Hi, Arnd,

I can change it as you metioned now.

Thanks!
-zw

> -----Original Message-----
> From: linux-kernel-owner at vger.kernel.org 
> [mailto:linux-kernel-owner at vger.kernel.org] On Behalf Of Arnd Bergmann
> Sent: Sunday, July 29, 2007 9:57 PM
> To: linuxppc-dev at ozlabs.org
> Cc: Zhang Wei-r63237; galak at kernel.crashing.org; 
> mporter at kernel.crashing.org; paulus at samba.org; 
> linux-kernel at vger.kernel.org
> Subject: Re: [PATCH 3/5 v3] Add the platform device support 
> with RapidIO to MPC8641HPCN platform.
> 
> On Thursday 26 July 2007, Zhang Wei wrote:
> > +
> > +static struct of_device_id mpc86xx_of_ids[] = {
> > +       { .type = "soc", },
> > +       { .compatible = "fsl,rapidio-delta", },
> > +       {},
> > +};
> 
> With the device tree source you have posted in 2/5, the 
> rapidio node is
> a child of the soc bus, and it doesn't have any children of its own.
> Therefore it is completely equivalent to _only_ add the soc type
> to mpc86xx_of_ids[], as in 
> 
> static struct of_device_id mpc86xx_of_ids[] = {
>        { .type = "soc", },
>        {},
> };
> 
> Even if you intend to add children to the rapidio node in the future,
> I'd think it would be more appropriate to have those scanned by
> the rapidio bus driver, not by of_platform.
> 
> 	Arnd <><
> 
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>