Fwd: [PATCH] bootwrapper: adds cuboot for MPC7448HPC2 platform

Scott Wood scottwood at freescale.com
Fri Jul 27 02:04:55 EST 2007


On Thu, Jul 26, 2007 at 04:59:02PM +1000, David Gibson wrote:
> > >+#define TARGET_HAS_ENET1
> > >+#include "ppcboot.h"
> 
> Including ppcboot.h without first defining TARGET_* defines which give
> the type of system seems... fragile at best, broken at worst.  Surely
> this can only work by accident.

What target do you suggest he define?  There happen to be none in
ppcboot.h that are appropriate, because there are no special fields for
this target (other than eth1).

And yes, it's fragile -- the entire bd_t mechanism is fragile.  In the
absence of a time machine, there's not much we can do about it other than
encourage people to upgrade their u-boot.

-Scott



More information about the Linuxppc-dev mailing list