[PATCH] Fix ibmvscsi client for multiplatform iSeries+pSeries kernel.

David Woodhouse dwmw2 at infradead.org
Thu Jul 26 17:46:37 EST 2007


On Thu, 2007-07-26 at 11:27 +1000, Michael Ellerman wrote:
> Nice that someone finally fixed this up.
> 
> But I get:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: 'FW_FEATURE_ISERIES' undeclared (first use in this function)
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: (Each undeclared identifier is reported only once
> drivers/scsi/ibmvscsi/ibmvscsi.c:1651: error: for each function it appears in.)
> drivers/scsi/ibmvscsi/ibmvscsi.c:1653: error: 'FW_FEATURE_VIO' undeclared (first use in this function)
> 
> Missing <asm/firmware.h> ? 

Hm, I wonder why it ever worked for me then...

Ah, it seems that <asm/time.h> only includes <asm/firmware.h> if
CONFIG_PPC_ISERIES. We should include <asm/firmware.h> directly from
ibmvscsi.c rather than relying on it being pulled in indirectly. I'll
send a new patch. Thanks.

-- 
dwmw2




More information about the Linuxppc-dev mailing list