[PATCH] xmon consistency clean up

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Jul 25 16:21:38 EST 2007


On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote:
> This patch cleans up xmon to keep consistency.
> 
> In xmon, we should use console I/O functions that are named the same
> as user space stdio functions. But commit
> 4d404edce30f911004850d472e05a31efd751662 broke this consistency.
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>
> ---
> 
> Index: linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> ===================================================================
> --- linux-powerpc-git.orig/arch/powerpc/xmon/nonstdio.c
> +++ linux-powerpc-git/arch/powerpc/xmon/nonstdio.c
> @@ -133,7 +133,7 @@ void xmon_printf(const char *format, ...
>         xmon_write(xmon_outbuf, n);
>  }
>  
> -void xmon_puts(const char *str)
> +void xmon_fputs(const char *str)
>  {
>         xmon_write(str, strlen(str)); 

Nah, keep it xmon_puts, since it doesn't take a stream argument and
define a "puts" for use by xmon core.

Ben.




More information about the Linuxppc-dev mailing list