[patch 1/3] ps3: Disk Storage Driver

Jeff Garzik jeff at garzik.org
Tue Jul 24 23:44:21 EST 2007


Andreas Schwab wrote:
> Jeff Garzik <jeff at garzik.org> writes:
> 
>> Andy Whitcroft wrote:
>>> Andrew Morton wrote:
>>>
>>>>> +	start_sector = req->sector*priv->blocking_factor;
>>>>> +	sectors = req->nr_sectors*priv->blocking_factor;
>>>> s/*/ * /.  checkpatch missed this.
>>> Ok, this is something we need to decide on.  Currently we only ask for
>>> consistent spacing on all the mathematic operators.  This is mostly as
>>> we do see a large number of non-spaced uses in defines and the like.
>>>
>>> I am happy to expand these tests so they are always spaced on both sides
>>> style if that is the preference.
>> That is most definitely the preference:  spaces surround operators.
>                                                           ^binary

Yes.  :)

	Jeff






More information about the Linuxppc-dev mailing list