[PATCH 19/25] [POWERPC] 85xxCDS: Allow 8259 cascade to share an MPIC interrupt line.

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Jul 24 11:48:12 EST 2007


On Mon, 2007-07-23 at 15:50 -0500, Kumar Gala wrote:
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -836,6 +836,7 @@ static struct irq_chip mpic_irq_chip = {
>         .mask           = mpic_mask_irq,
>         .unmask         = mpic_unmask_irq,
>         .eoi            = mpic_end_irq,
> +       .end            = mpic_unmask_irq,
>         .set_type       = mpic_set_irq_type,
>  }; 

Nope, that doesn't look correct and shouldn't be in this patch in the
first place.

end() is flow control business, not chip business, so it's really
something that needs to be fixed in the fasteoi handler for -rt I
suppose.

Ben.





More information about the Linuxppc-dev mailing list