[PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path
Jerry Van Baren
gerald.vanbaren at smiths-aerospace.com
Sat Jul 21 02:46:48 EST 2007
Scott Wood wrote:
> Jerry Van Baren wrote:
>> Scott Wood wrote:
>>> Kim Phillips wrote:
>>>> The LIBFDT implementation replaces any existing /chosen with its fixed
>>>> up version.
>> Sort of. If /chosen doesn't exist, it creates it.
>> If /chosen exists and "force" parameter is false, it doesn't touch it.
>> If "force" is true, it creates or fixes up properties. The "bootm"
>> command passes in force == false. The "fdt" command passes in force ==
>> The "force" parameter was added to sort of emulate the previous bootm
>> command behavior (but behave better in the case where /chosen already
> The problem is that "force" is node-granular, rather than
> property-granular -- If I add a /chosen/linux,stdout-path in the
> original dts (or via an fdt command), then bootm will decline to add
> bootargs and initrd information to the /chosen node.
Yes, making "force" property-granular makes more sense. I'll add that
to my u-boot-fdt repo.
FWIIW, my original proposal (and code) was to *REMOVE* the automagic
modifications of the fdt blob from the bootm command. My original
proposal was to replace "bootm" in scripts (or in the user's fingers)
with "fdt chosen && fdt env && fdt bd_t && bootm" (or an appropriate
combination thereof). I was shouted down. ;-)
IMHO, having bootm modify the fdt blob is a poor practice. Bootm's
mandate is to boot an image from memory, it *shouldn't* be to rewrite
the fdt blob. Unfortunately, we had an existing practice (poor, IMHO)
of having bootm rewrite the fdt blob and so the current implementation
was done to meet the "user expectation" of bootm "just working" without
needing to add "fdt xyz" before the bootm command.
(wipes the foamy spit off his face)
More information about the Linuxppc-dev