[PATCH 2/2] fix showing xmon help
Ishizaki Kou
kou.ishizaki at toshiba.co.jp
Fri Jul 20 18:15:09 EST 2007
Milton Miller <miltonm at bga.com> wrote:
> On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote:
>
> > Milton Miller <miltonm at bga.com> writes:
> >
> >>> case '?':
> >>> - printf(help_string);
> >>> + xmon_puts(help_string);
> >>> break;
> >>>
> >>
> >> nonstdio.h #defines printf to xmon_printf. Please add a similar
line
> >> for puts, and use the define here. (It will avoid an unnecessary
> >> difference with the user space version).
> >
> > User space puts add a newline, which this xmon_puts doesn't.
> >
> > Andreas.
>
> Good point. This should be xmon_fputs #defined to fputs.
>
> milton
Should we change like below?
define fputs:
#define fputs(str,stream) xmon_fputs(str) /* stream is ignored. */
show the help string:
fputs(help_string, stdout);
Best regards,
Kou Ishizaki
More information about the Linuxppc-dev
mailing list