[PATCH 30/61] fsl_soc: Update the way get_brgfreq() finds things in the device tree.
galak at kernel.crashing.org
Fri Jul 20 00:55:32 EST 2007
On Jul 18, 2007, at 11:32 AM, Scott Wood wrote:
> Kumar Gala wrote:
>>> diff --git a/arch/powerpc/boot/dts/mpc8272ads.dts b/arch/powerpc/
>>> index 4d09dca..16a77f4 100644
>>> --- a/arch/powerpc/boot/dts/mpc8272ads.dts
>>> +++ b/arch/powerpc/boot/dts/mpc8272ads.dts
>>> @@ -119,12 +119,11 @@
>>> #address-cells = <1>;
>>> #size-cells = <1>;
>>> #interrupt-cells = <2>;
>>> - device_type = "cpm";
>>> - model = "CPM2";
>>> + compatible = "fsl,mpc8272-cpm", "fsl,cpm2", "fsl,cpm";
>> Does 'fsl,cpm' really mean anything useful?
> Yes. It's can't be used on its own to show the complete
> programming model, but there are lots of common things that it does
> get_brgfreq() uses it to locate nodes which have an fsl,brg-
> frequency property.
I think we should introduce 'fsl,cpm' in a second pass once its clear
what all the common points are. We can than also see if QE fits into
it at that point.
>>> ranges = <00000000 00000000 20000>;
>>> reg = <0 20000>;
>>> command-proc = <119c0>;
>>> - brg-frequency = <17D7840>;
>>> + fsl,brg-frequency = <d#25000000>;
>> Leave brg-frequency, and make a note about it being deprecated.
> The CPM binding is changed in so many other ways that are much
> harder to make backward compatible that I don't really see much
> point in doing so here.
Can you enumerate some of the other changes.
>> Also, take a look at QE it has a similar concept.
> It'd be nice to extend this binding to include QE (and at some
> point down the road, merge the code)... I just didn't have time
> this time around.
As I stated above, I think we should drop 'fsl,cpm' for now until we
can come up with a good defn. of what it means rather than a
convenience to mean (fsl-cpm2 and fsl-cpm1).
More information about the Linuxppc-dev