[PATCH 2/2] fix showing xmon help
Milton Miller
miltonm at bga.com
Thu Jul 19 01:51:50 EST 2007
On Wed Jul 18 19:26:40 EST 2007, Ishizaki Kou wrote:
> In some configuration, xmon help string is larger than xmon_printf
> buffer. We need not to use printf. This patch adds xmon_puts and
> change to use it to show help string.
[Since I'm requesting changes I'll suggest a new change log.]
In some configurations the xmon help string is larger than the
xmon_printf buffer. However, since its a fixed string we do not need
printf to format it. This patch adds xmon_puts and uses it to show the
help string.
> case '?':
> - printf(help_string);
> + xmon_puts(help_string);
> break;
>
nonstdio.h #defines printf to xmon_printf. Please add a similar line
for puts, and use the define here. (It will avoid an unnecessary
difference with the user space version).
Thanks,
milton
More information about the Linuxppc-dev
mailing list