[PATCH 1/2] Fix error checking in Vitesse IRQ config
Andy Fleming
afleming at freescale.com
Wed Jul 18 16:35:50 EST 2007
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <afleming at freescale.com>
---
I made a really stupid mistake in the 4 patches I sent out, earlier. I
thought those patches had been tested, but they hadn't been. This one
corrects a tiny error in the patch, and they have now been tested. As before
this change can be pulled from:
http://opensource.freescale.com/pub/scm/linux-2.6-85xx.git netdev
Really, REALLY sorry about that. I have been given a paper bag of appropriate
size and shape to fit over my head.
drivers/net/phy/vitesse.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
index 6a53856..8874497 100644
--- a/drivers/net/phy/vitesse.c
+++ b/drivers/net/phy/vitesse.c
@@ -109,7 +109,7 @@ static int vsc824x_config_intr(struct phy_device *phydev)
*/
err = phy_read(phydev, MII_VSC8244_ISTAT);
- if (err)
+ if (err < 0)
return err;
err = phy_write(phydev, MII_VSC8244_IMASK, 0);
--
1.5.0.2.230.gfbe3d-dirty
More information about the Linuxppc-dev
mailing list