[PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency"

Guennadi Liakhovetski g.liakhovetski at gmx.de
Wed Jul 18 05:58:22 EST 2007


On Tue, 17 Jul 2007, Vitaly Bordug wrote:

> > Please don't do this; drivers/i2c/chips/ds1337.c is deprecated.  You
> > should be using the RTC-class driver in drivers/rtc/rtc-ds1307.c, which
> > has a non-device-specific API that can be used.
> > 
> > The ppc_md RTC functions should really just go away, though -- setting
> > the clock on bootup can be done by generic code, and periodically
> > updating the RTC when using NTP can be done from userspace.
> 
> If those ppc_md hookups would be declared deprecated, there's no much sense in the upper,
> apparently. But I am not sure they will be... I'm inclined to let this patch floating since
> interacting with rtc class from within BSP code just does not worth it.

Exactly! Don't interact with it. Just leave it alone. No need to re-write 
[sg]et_rtc_time, bother with setting system time on bootup... Just let the 
rtc driver and framework do it for you.

Thanks
Guennadi
---
Guennadi Liakhovetski



More information about the Linuxppc-dev mailing list