[PATCH] the wrong variable checked after request_irq()
viro at ftp.linux.org.uk
Mon Jul 16 08:02:16 EST 2007
On Mon, Jul 16, 2007 at 07:40:38AM +1000, Benjamin Herrenschmidt wrote:
> On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote:
> > Signed-off-by: Al Viro <viro at zeniv.linux.org.uk>
> Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> Out of curiosity, how did you pick it up ? You have some automated tool
> to catch that (or sparse changes) or you just did -lots- of code
> inspection ?
While testing sparse changes, actually (comparing pointers to null
pointer constant spelled without a cast to void *)... That gave several
hundred hits, most of them being immediately obvious (picking the lines
by file and line number and looking through the list had eliminated all
but about a dozen or two). Several were not...
More information about the Linuxppc-dev