[PATCH] fix showing xmon help

Ishizaki Kou kou.ishizaki at toshiba.co.jp
Fri Jul 13 19:11:50 EST 2007


> On Thu, 2007-07-12 at 16:59 +0900, Ishizaki Kou wrote:
> > In some configuration, xmon help string is larger than xmon output
> > buffer.  To show whole help string, this patch splits it into 2
parts.
> > 
> > Signed-off-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>
 (snip)

> I'm not sure I like the fix though, it's a bit of a kludge :)
> 
> We don't actually need to printf() the help string, so what'd be nicer
> is to add an xmon_puts() to arch/powerpc/xmon/nonstdio.c which just
> calls xmon_write(s, strlen(s)) and use that for printing the help
> string.

Thank you for your suggestion.

You're right. I'll send a new patch.

Best regards,
Kou Ishizaki



More information about the Linuxppc-dev mailing list