[RFC][PATCH 6/8] Walnut DTS

[Segher Boessenkool]

>>> +	plb {
>>> +		ranges;
>>
>> Please make the valid address ranges explicit here.
>
> Meaning what exactly?  I thought just specifying "ranges;" simply said
> "the addresses from this node don't have any translation from the  
> parent
> node" (or something like that).

Just list the actual ranges that sit on the PLB bus.  It is
good to be more explicit with these things (for example, the
kernel will have more information to work from when deciding
whether to apply a certain workaround for broken device trees
or not).

>>> +		SDRAM0: memory-controller {
>>> +			compatible = "ibm,sdram-405gp", "ibm,sdram-440gp";
>>
>> It's a bit weird to mention 440 here, since 405 is older.
>> Not a real problem, but if you still can change all relevant
>> OS code and device trees, I'd swap it around (make 440 trees
>> include the 405 "compatible" value).  Can you still do that
>> or is there a too big installed base already?
>
> The installed base for 440 exists of exactly 1 completely non- 
> functional
> board ;).  I can change it.

Yes exactly, let's do that while we still can.

>>> +			UART0: serial at ef600300 {
>>> +				current-speed = <2580>;
>>
>> Write this in decimal?
>
> In a comment?  Or?

Just in the code.  The syntax is <d#9600> I believe?

>> Quite a nice tree btw :-)
>
> Thanks!  Easy to do when there's nothing in it ;)

Well I didn't want to put it like that, but since you bring it
up yourself... :-)


Segher